[Docutils-develop] [docutils:patches] #137 Fix no source and lineno was set to caption of table

[Takeshi KOMIYA]

---

** [patches:#137] Fix no source and lineno was set to caption of table**

**Status:** open
**Group:** None
**Created:** Sat Feb 18, 2017 05:23 AM UTC by Takeshi KOMIYA
**Last Updated:** Sat Feb 18, 2017 05:23 AM UTC
**Owner:** nobody
**Attachments:**

- [location_for_table_captions.patch](https://sourceforge.net/p/docutils/patches/137/attachment/location_for_table_captions.patch) (639 Bytes; application/octet-stream)


In Sphinx, we use source and line information of text nodes for I18N feature.

In docutils-0.13.2, it seems a caption of table does not have both attributes. The table node (parent) don't have also.
The attached patch sets the source and line information to the caption node.

Could you review this please?

Note: it seems there are no test cases for source and lines. So I simply added the directive code. Please let me know if any good place to do that.

Thanks,


---

Sent from sourceforge.net because docutils-***@lists.sourceforge.net is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Brecht Machiels]

Related: https://sourceforge.net/p/docutils/feature-requests/41/


---

** [patches:#137] Fix no source and lineno was set to caption of table**

**Status:** open
**Group:** None
**Created:** Sat Feb 18, 2017 05:23 AM UTC by Takeshi KOMIYA
**Last Updated:** Sat Feb 18, 2017 05:23 AM UTC
**Owner:** nobody
**Attachments:**

- [location_for_table_captions.patch](https://sourceforge.net/p/docutils/patches/137/attachment/location_for_table_captions.patch) (639 Bytes; application/octet-stream)


In Sphinx, we use source and line information of text nodes for I18N feature.

In docutils-0.13.2, it seems a caption of table does not have both attributes. The table node (parent) don't have also.
The attached patch sets the source and line information to the caption node.

Could you review this please?

Note: it seems there are no test cases for source and lines. So I simply added the directive code. Please let me know if any good place to do that.

Thanks,


---

Sent from sourceforge.net because docutils-***@lists.sourceforge.net is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Günter Milde]

- **status**: open --> closed-fixed
- **Comment**:

Applied in Revision 8039.



---

** [patches:#137] Fix no source and lineno was set to caption of table**

**Status:** closed-fixed
**Group:** None
**Created:** Sat Feb 18, 2017 05:23 AM UTC by Takeshi KOMIYA
**Last Updated:** Mon Feb 20, 2017 08:19 AM UTC
**Owner:** nobody
**Attachments:**

- [location_for_table_captions.patch](https://sourceforge.net/p/docutils/patches/137/attachment/location_for_table_captions.patch) (639 Bytes; application/octet-stream)


In Sphinx, we use source and line information of text nodes for I18N feature.

In docutils-0.13.2, it seems a caption of table does not have both attributes. The table node (parent) don't have also.
The attached patch sets the source and line information to the caption node.

Could you review this please?

Note: it seems there are no test cases for source and lines. So I simply added the directive code. Please let me know if any good place to do that.

Thanks,


---

Sent from sourceforge.net because docutils-***@lists.sourceforge.net is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.